Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FTB App import instance path detection #2166

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Update FTB App import instance path detection #2166

merged 3 commits into from
Jun 9, 2024

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Feb 26, 2024

read the ftb instance path from their settings: #1825 (comment)

@Trial97
Updated ftb app import instance detection
344398f 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added enhancement New feature or request simple change changelog:added A PR that appears under "Added" in the changelog labels Feb 26, 2024
@Trial97 Trial97 mentioned this pull request Feb 26, 2024
Merged
@Trial97
Removed static path
27e76d0 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added this to the 9.0 milestone Mar 27, 2024
@Trial97
Added the new ftb settings path
1c3c9d2 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Ryex
Ryex approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@Ryex Ryex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to double check the behavior of node's os.homedir compared to qt QDir::homePath
but this looks good

@Trial97 Trial97 modified the milestones: 9.0, 8.4 Jun 9, 2024
@Trial97 Trial97 added changelog:fixed A PR that appears under "Fixed" in the changelog backport release-8.x Backport PR automatically and removed changelog:added A PR that appears under "Added" in the changelog labels Jun 9, 2024
@Trial97 Trial97 merged commit 154f481 into PrismLauncher:develop Jun 9, 2024
33 checks passed
@Trial97 Trial97 deleted the ftb2 branch June 9, 2024 21:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Successfully created backport PR for release-8.x:

@github-actions github-actions bot mentioned this pull request Jun 9, 2024
Merged
@TayouVR TayouVR changed the title Updated ftb app import instance detection Update TFB App import instance path detection Jun 22, 2024
@Trial97 Trial97 changed the title Update TFB App import instance path detection Update FTB App import instance path detection Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryex Ryex Ryex approved these changes

@TheKodeToad TheKodeToad TheKodeToad approved these changes

Assignees
No one assigned
Labels
backport release-8.x Backport PR automatically changelog:fixed A PR that appears under "Fixed" in the changelog enhancement New feature or request simple change
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Trial97 @Ryex @TheKodeToad